Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/vcenter] Could use VSAN metrics for vCenter #33556

Closed
BominRahmani opened this issue Jun 13, 2024 · 1 comment
Closed

[receiver/vcenter] Could use VSAN metrics for vCenter #33556

BominRahmani opened this issue Jun 13, 2024 · 1 comment
Assignees
@BominRahmani
Labels
enhancement New feature or request receiver/vcenter

Comments

@BominRahmani
Copy link
Contributor

Component(s)

receiver/vcenter

Is your feature request related to a problem? Please describe.

A suite of VSAN related metrics would be useful.

Describe the solution you'd like

I would like to add the following suite of VSAN related metrics:

vcenter.cluster.vsan.throughput       (direction={read/write})
vcenter.cluster.vsan.iops             (direction={read/write})
vcenter.cluster.vsan.cache.hit_rate
vcenter.cluster.vsan.latency.avg      (direction={read/write})

vcenter.host.vsan.throughput          (direction={read/write})
vcenter.host.vsan.iops                (direction={read/write})
vcenter.host.vsan.congestions
vcenter.host.vsan.cache.hit_rate
vcenter.host.vsan.latency.avg         (direction={read/write})

vcenter.vm.vsan.throughput            (direction={read/write})
vcenter.vm.vsan.iops                  (direction={read/write})
vcenter.vm.vsan.latency.avg           (direction={read/write})

The metrics in question will be retrieved from the VsanPerfQuerySpec data object. The following entity types will be used:

  • Cluster-related metrics: cluster-domclient
  • Host-related metrics: host-domclient
  • Virtual machine-related metrics: virtual-machine

For a list of the metrics and their respective details, please refer to the documentation.

Describe alternatives you've considered

No response

Additional context

No response
@BominRahmani BominRahmani added enhancement New feature or request needs triage New item requiring triage labels Jun 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@BominRahmani BominRahmani changed the title Could use VSAN metrics for vCenter [receiver/vcenter] Could use VSAN metrics for vCenter Jun 13, 2024
@djaglowski djaglowski removed the needs triage New item requiring triage label Jun 14, 2024
This was referenced Jun 19, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@BominRahmani BominRahmani mentioned this issue Jul 12, 2024
Merged
@StefanKurek StefanKurek mentioned this issue Jul 15, 2024
Merged
@StefanKurek StefanKurek mentioned this issue Jul 24, 2024
Merged
djaglowski pushed a commit that referenced this issue Jul 26, 2024
@StefanKurek
[receiver/vcenter] Adds vSAN metrics for Virtual Machines (#34082)
51f4a89 
**Description:** <Describe what has changed.>

Adds a set of vSAN metrics for Virtual Machines.
```
vcenter.vm.vsan.throughput          (direction={read/write})
vcenter.vm.vsan.iops                (direction={read/write})
vcenter.vm.vsan.latency.avg         (direction={read/write})
```

**Link to tracking Issue:** <Issue number if applicable>
#33556 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit tests added for scraper.
Could not add client tests as `govmomi` vSAN simulator currently not
implemented.
Tested against live environment.

**Documentation:** <Describe the documentation added.>
New documentation generated
djaglowski pushed a commit that referenced this issue Jul 26, 2024
@BominRahmani @StefanKurek
[receiver/vcenter] Adds vCenter VSAN Host metrics (#34063)
8c25e9f 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The following PR adds VSAN host metric collection. The following metrics
are collected
```
vcenter.host.vsan.throughput          (direction={read/write})
vcenter.host.vsan.iops                (direction={read/write})
vcenter.host.vsan.congestions
vcenter.host.vsan.cache.hit_rate
vcenter.host.vsan.latency.avg         (direction={read/write})
```

**Link to tracking Issue:** #33556

**Testing:** <Describe what testing was performed and which tests were
added.>
Added mock data fields in order to test vsan host metric scraping.
Updated golden test file output.

**Documentation:** <Describe the documentation added.>
Updated documentation using `make generate`

Co-authored-by: Stefan Kurek <[email protected]>
djaglowski pushed a commit that referenced this issue Jul 29, 2024
@StefanKurek
[receiver/vcenter] Adds vSAN metrics for Clusters (#34084)
2ae66fe 
**Description:** <Describe what has changed.>
Waiting on
#34082
to be merged first.
Adds a set of default disabled vSAN metrics for Clusters.

```
vcenter.cluster.vsan.throughput          (direction={read/write})
vcenter.cluster.vsan.iops                (direction={read/write})
vcenter.cluster.vsan.latency.avg         (direction={read/write})
vcenter.cluster.vsan.congestions
```

**Link to tracking Issue:** <Issue number if applicable>
#33556 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit tests added for scraper.
Could not add client tests as govmomi vSAN simulator currently not
implemented.
Test against live environment.

**Documentation:** <Describe the documentation added.>
New documentation generated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BominRahmani BominRahmani

Labels
enhancement New feature or request receiver/vcenter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djaglowski @BominRahmani