Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic conventions for instrumentation library, switch to use this new one #2602

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team March 3, 2021 22:34
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #2602 (d010c4f) into main (2a743aa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2602   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files         271      271           
  Lines       15445    15446    +1     
=======================================
+ Hits        14213    14214    +1     
  Misses        850      850           
  Partials      382      382           
Impacted Files Coverage Δ
translator/trace/protospan_translation.go 92.41% <ø> (ø)
translator/trace/jaeger/jaegerproto_to_traces.go 90.67% <100.00%> (ø)
translator/trace/jaeger/traces_to_jaegerproto.go 93.60% <100.00%> (ø)
translator/trace/zipkin/traces_to_zipkinv2.go 94.41% <100.00%> (ø)
translator/trace/zipkin/zipkinv2_to_traces.go 89.91% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a743aa...d010c4f. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit bf8b945 into open-telemetry:main Mar 3, 2021
@bogdandrutu bogdandrutu deleted the instrumentationlib branch March 3, 2021 23:10
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants