Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move service/builder to internal, no need to expose public #2625

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

bogdandrutu
Copy link
Member

Followup after #2624

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team March 8, 2021 20:53
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #2625 (7e74f05) into main (d9099c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2625   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files         274      274           
  Lines       15455    15455           
=======================================
  Hits        14222    14222           
  Misses        850      850           
  Partials      383      383           
Impacted Files Coverage Δ
service/internal/builder/builder.go 100.00% <ø> (ø)
service/internal/builder/exporters_builder.go 81.73% <ø> (ø)
service/internal/builder/extensions_builder.go 80.76% <ø> (ø)
service/internal/builder/pipelines_builder.go 88.42% <ø> (ø)
service/internal/builder/receivers_builder.go 72.13% <ø> (ø)
service/service.go 52.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9099c5...7e74f05. Read the comment docs.

@bogdandrutu bogdandrutu merged commit b6cf092 into open-telemetry:main Mar 8, 2021
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
@bogdandrutu bogdandrutu deleted the internalbuilder branch February 1, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants