Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform goldendataset for traces to not depend on protos. #3229

Closed
Tracked by #3104
bogdandrutu opened this issue May 18, 2021 · 2 comments
Closed
Tracked by #3104

Transform goldendataset for traces to not depend on protos. #3229

bogdandrutu opened this issue May 18, 2021 · 2 comments
Assignees
@IrisTuntun
Labels
good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Milestone
Phase1-Trace-GA-R...

Comments

@bogdandrutu
Copy link
Member

Right now the generator generates proto structs instead of pdata structs, see https://github.com/open-telemetry/opentelemetry-collector/blob/main/internal/goldendataset/span_generator.go#L50 which should return pdata.Span in this case.
@bogdandrutu bogdandrutu added help wanted Good issue for contributors to OpenTelemetry Service to pick up good first issue Good for newcomers labels May 18, 2021
@bogdandrutu bogdandrutu added this to the Phase1-GA-Roadmap milestone May 18, 2021
@bogdandrutu bogdandrutu mentioned this issue May 19, 2021
Closed
9 tasks
@IrisTuntun
Copy link
Contributor

Hi, can I take this issue?

This was referenced May 24, 2021
Closed
Merged
@bogdandrutu
Copy link
Member Author

Completely fixed in #3377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IrisTuntun IrisTuntun

Labels
good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
Phase1-Trace-GA-Roadmap
Development

No branches or pull requests
2 participants
@bogdandrutu @IrisTuntun