Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service state is not cleaned up when service errors on Start #6352

Closed
cpheps opened this issue Oct 19, 2022 · 0 comments · Fixed by #6351
Closed

Service state is not cleaned up when service errors on Start #6352

cpheps opened this issue Oct 19, 2022 · 0 comments · Fixed by #6351
Labels
bug Something isn't working

Comments

@cpheps
Copy link
Contributor

cpheps commented Oct 19, 2022

Describe the bug
Similar to #6238 if the service.Start call errors here it doesn't clean up any state. Mainly this doesn't clean up telemetryInitializer causing it to leave global state.

What version did you use?
Version: v0.62.0

Environment
OS: macOS 12.6
Compiler(if manually compiled): go 1.19
@cpheps cpheps added the bug Something isn't working label Oct 19, 2022
@cpheps cpheps mentioned this issue Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added cleanup if service errors on Start observIQ/opentelemetry-collector
1 participant
@cpheps