Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutdown logic in persistent queue to not require consumers to be closed first #8899

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from a team and dmitryax November 14, 2023 20:15
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (6f65b63) 90.86% compared to head (015c11c) 90.86%.
Report is 1 commits behind head on main.

Files Patch % Lines
...rter/exporterhelper/internal/persistent_storage.go 65.21% 4 Missing and 4 partials ⚠️
exporter/exporterhelper/internal/mock_storage.go 71.42% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8899   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files         317      317           
  Lines       17193    17204   +11     
=======================================
+ Hits        15623    15633   +10     
+ Misses       1280     1279    -1     
- Partials      290      292    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu force-pushed the fixshutdown branch 2 times, most recently from f373312 to 9aac32a Compare November 14, 2023 20:31
@bogdandrutu bogdandrutu merged commit 560bd1d into open-telemetry:main Nov 14, 2023
31 of 32 checks passed
@bogdandrutu bogdandrutu deleted the fixshutdown branch November 14, 2023 21:55
@github-actions github-actions bot added this to the next release milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants