From de2608b94409e769940fa4858cb2c08181d252f8 Mon Sep 17 00:00:00 2001 From: Pablo Baeyens Date: Wed, 28 Sep 2022 15:16:41 -0400 Subject: [PATCH 1/3] [receiver/otlp] Rewrite confusing logs --- receiver/otlpreceiver/otlp.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/receiver/otlpreceiver/otlp.go b/receiver/otlpreceiver/otlp.go index 0156cb2e106..ea78c1d948f 100644 --- a/receiver/otlpreceiver/otlp.go +++ b/receiver/otlpreceiver/otlp.go @@ -22,6 +22,7 @@ import ( "net/http" "sync" + "go.uber.org/zap" "google.golang.org/grpc" "go.opentelemetry.io/collector/component" @@ -67,7 +68,7 @@ func newOtlpReceiver(cfg *Config, settings component.ReceiverCreateSettings) *ot } func (r *otlpReceiver) startGRPCServer(cfg *configgrpc.GRPCServerSettings, host component.Host) error { - r.settings.Logger.Info("Starting GRPC server on endpoint " + cfg.NetAddr.Endpoint) + r.settings.Logger.Info("Starting GRPC server", zap.String("endpoint", cfg.NetAddr.Endpoint)) gln, err := cfg.ToListener() if err != nil { @@ -85,7 +86,7 @@ func (r *otlpReceiver) startGRPCServer(cfg *configgrpc.GRPCServerSettings, host } func (r *otlpReceiver) startHTTPServer(cfg *confighttp.HTTPServerSettings, host component.Host) error { - r.settings.Logger.Info("Starting HTTP server on endpoint " + cfg.Endpoint) + r.settings.Logger.Info("Starting HTTP server", zap.String("endpoint", cfg.Endpoint)) var hln net.Listener hln, err := cfg.ToListener() if err != nil { From 424e5341834017c5823ff81159e01b7cc5b47c86 Mon Sep 17 00:00:00 2001 From: Pablo Baeyens Date: Wed, 28 Sep 2022 15:21:31 -0400 Subject: [PATCH 2/3] Add changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4b975e6c5a9..dfdee9f3e8f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +### 💡 Enhancements 💡 + +- `receiver/otlp`: Rewrite logs related to servers (#6174) + ## v0.61.0 Beta ### 🛑 Breaking changes 🛑 From 61e1e964e61ce891af030806466cf035f3b3c440 Mon Sep 17 00:00:00 2001 From: Pablo Baeyens Date: Wed, 28 Sep 2022 21:48:03 +0200 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dfdee9f3e8f..7f766136751 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ ### 💡 Enhancements 💡 -- `receiver/otlp`: Rewrite logs related to servers (#6174) +- `receiver/otlp`: Make logs related to gRCPC and HTTP server startup clearer (#6174) ## v0.61.0 Beta