Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPORTER] exporter endpoint doesn't support ipv6 #3073

Closed
marcalff opened this issue Sep 27, 2024 Discussed in #3056 · 1 comment · Fixed by #3081
Closed

[EXPORTER] exporter endpoint doesn't support ipv6 #3073

marcalff opened this issue Sep 27, 2024 Discussed in #3056 · 1 comment · Fixed by #3081
Assignees
@owent
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@marcalff
Copy link
Member

Discussed in #3056

Originally posted by qusijun September 9, 2024
now, UrlParser can't parse ipv6 correctly , do we have the plan to support ipv6?

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 27, 2024
@marcalff
Copy link
Member Author

marcalff commented Sep 27, 2024 •
edited
Loading

The URL parser just looks for a : character in a url, it will be very confused when parsing IPv6 addresses.

https://github.com/open-telemetry/opentelemetry-cpp/blob/main/ext/include/opentelemetry/ext/http/common/url_parser.h

@marcalff marcalff mentioned this issue Sep 27, 2024
Open
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 2, 2024
@owent owent self-assigned this Oct 7, 2024
@owent owent mentioned this issue Oct 7, 2024
Merged
3 tasks
@marcalff marcalff mentioned this issue Oct 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owent owent

Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EXPORTER] Fix URL in ES exporter, fix ipv6 supporting for http client. owent/opentelemetry-cpp
2 participants
@owent @marcalff