Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and enhance tracing support for ad service service (Java) #60

Closed
2 of 10 tasks
cartersocha opened this issue May 30, 2022 · 2 comments · Fixed by #150
Closed
2 of 10 tasks

Review and enhance tracing support for ad service service (Java) #60

cartersocha opened this issue May 30, 2022 · 2 comments · Fixed by #150
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cartersocha
Copy link
Contributor

cartersocha commented May 30, 2022

The following is a list of requirements that we need to evaluate before declaring v1 for trace telemetry. These requirements are across the entire application; Not all services will meet all requirements. Determine the relevant features for this service.

  • Automatic Instrumentation is being used where appropriate.
  • Library instrumentation is being used if automatic instrumentation is unavailable.
  • Services extend automatic instrumentation. #151
  • Automatic and Manual Context Propagation are being demonstrated.
    • Interprocess context propagation is demonstrated.
  • Telemetry is not being sampled upfront.
  • Telemetry is not being filtered upfront.
  • Baggage is being set and read appropriately (i.e., baggage must be explicitly set as attributes on spans)

Referencing: #42

Service: https://github.com/open-telemetry/opentelemetry-demo-webstore/blob/main/src/adservice/README.md

@puckpuck
Copy link
Contributor

Should we check this one as well for Java?

  • Library instrumentation is being used if automatic instrumentation is unavailable.

@julianocosta89
Copy link
Member

@puckpuck we could maybe add a Feature Flag to decide if the Jave OTel Agent will or not be deployed to the AdService.
And when not, then the library instrumentation should be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants