Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CurrencyService] Add C++ Metrics #759

Merged
merged 12 commits into from
Mar 1, 2023

Conversation

julianocosta89
Copy link
Member

@julianocosta89 julianocosta89 commented Feb 24, 2023

Changes

This PR adds the manual metric app_currency_counter to the currency service.
The metric counts how many times a specific currency was converted.

image

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@julianocosta89 julianocosta89 requested a review from a team February 24, 2023 11:52
@julianocosta89 julianocosta89 self-assigned this Feb 24, 2023
@julianocosta89
Copy link
Member Author

@lalitb would you mind taking a look at this one?

@cartersocha
Copy link
Contributor

Could you open and link a pr to the website docs adding this as a user created metric ?

@julianocosta89
Copy link
Member Author

Could you open and link a pr to the website docs adding this as a user created metric ?

Done!

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for enabling C++ metrics in demo.

src/currencyservice/src/meter_common.h Outdated Show resolved Hide resolved
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! This runs fine.

@julianocosta89 julianocosta89 merged commit a60ca4f into open-telemetry:main Mar 1, 2023
@julianocosta89 julianocosta89 deleted the cpp-metrics branch March 1, 2023 11:56
styblope pushed a commit to instana/opentelemetry-demo that referenced this pull request Mar 12, 2023
* Add cpp metrics

* Add IntCounter to CurrencyService

* changelog

* changelog

* Fix indentantion

* Add line break

* Remove unnecessary comma

* Remove unnecessary includes

* Apply suggestions
mat-rumian pushed a commit to SumoLogic/opentelemetry-demo that referenced this pull request Mar 20, 2023
* Add cpp metrics

* Add IntCounter to CurrencyService

* changelog

* changelog

* Fix indentantion

* Add line break

* Remove unnecessary comma

* Remove unnecessary includes

* Apply suggestions
juliangiuca pushed a commit to juliangiuca/opentelemetry-demo that referenced this pull request Apr 12, 2023
* Add cpp metrics

* Add IntCounter to CurrencyService

* changelog

* changelog

* Fix indentantion

* Add line break

* Remove unnecessary comma

* Remove unnecessary includes

* Apply suggestions
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* Add cpp metrics

* Add IntCounter to CurrencyService

* changelog

* changelog

* Fix indentantion

* Add line break

* Remove unnecessary comma

* Remove unnecessary includes

* Apply suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants