-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement grpc.StatsHandler
for grpc instrumentation
#197
Comments
The stats handler approach also allows cases to be captured that the interceptors do not, like a failure to decode the message. We ran into that case with OpenTracing using interceptors where a mismatching proto definition was used between the client and server. There was no indication in metrics, traces or logs that a request had even reached the server, making the issue more difficult to diagnose. |
* Make span start/end configuration more greppable Rename SpanOption to StartOption Rename StartOptions to StartConfig Rename EndOptions to EndConfig fixes #197
I quickly implemented https://github.com/bakins/otel-grpc-statshandler as I ran into similar issues. Needs more testing, etc. |
any news ? |
See OpenCensus https://godoc.org/go.opencensus.io/plugin/ocgrpc
Much easier to use and implement, now:
After:
The text was updated successfully, but these errors were encountered: