Replace probe.Event with ptrace.ScopeSpans
#1207
Draft
+1,857
−1,248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the pdata module as the data-model for the project.
The collector will default to span kind internal. Test that the SDK set span kind is captured and set.
Expect sampled flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements part of #1177. It removes the
probe.Eventtype and replaces its use withptrace.ScopeSpans. It does not replace theControllerwith a collector receiver and newHandlertype (like #1177). The goal here is to lay the foundation from which we can build out the collector receiver and generalize the probe handler.Resolve #1125