-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the B3 propagator out of the API #1012
Move the B3 propagator out of the API #1012
Comments
I'd second option (2). |
I'm slightly confused by the update to the spec from open-telemetry/opentelemetry-specification#735 that says:
My confusion comes from the fact that I don't see where the "officially supported protocols" are defined. The closest I can find is (also added in that PR):
Does the fact that B3 is not listed in the "MAY include" statement mean that the API MAY NOT include it? I think the contrib repo would qualify as "maintained by the OpenTelemetry organization", so moving the B3 propagator there wouldn't run afoul of the first requirement. Does the "MUST be distributed as OpenTelemetry extension packages" statement mean that it MUST be in contrib, or would simply having a separate Go module in this repo suffice? |
I share this confusion 😞
Agreed.
I'm not sure. It seems to me that was written in a Java paradigm and I'm not exactly sure how to translate that as you seem to be as well. I think the approach we decided on in the SIG meeting:
Will conform to the spec based on our similar understanding and allow extension in the future. |
In the Java codebase, the source code is in the main I think having it in the |
Related to open-telemetry/opentelemetry-specification#735 and recent feedback:
Possible destinations:
go.opentelemetry.io/otel/propagators
package that is dedicated to opensource trace context standards.otel
package with an extension.go.opentelemetry.io/contrib/propagators
package.My recommendation would be (2).
The text was updated successfully, but these errors were encountered: