Create resource.Default() with required attributes/default values #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add metric controller and tracer provider tests for resources
Codecov Report
@@ Coverage Diff @@
## main #1507 +/- ##
=======================================
- Coverage 77.7% 77.7% -0.1%
=======================================
Files 127 127
Lines 6683 6697 +14
=======================================
+ Hits 5195 5205 +10
- Misses 1244 1246 +2
- Partials 244 246 +2
|
evantorrie
requested review from
Aneurysm9,
dashpole,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Aneurysm9
approved these changes
Feb 10, 2021
MrAlias
approved these changes
Feb 12, 2021
+ some small CHANGELOG PR addition, rewording + change default resource servicename to `unknown_service:go` (this matches the Java codebase which uses `unknown_service:java`)
Merged
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
…en-telemetry#1507) * Create resource.Default() with required attributes/default values Add metric controller and tracer provider tests for resources * Updated CHANGELOG * PR comments + some small CHANGELOG PR addition, rewording + change default resource servicename to `unknown_service:go` (this matches the Java codebase which uses `unknown_service:java`)
This was referenced Mar 7, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per changes to the OpenTelemetry spec open-telemetry/opentelemetry-specification#1294, this PR makes available a "default" Resource. If a metric or trace provider does not explicitly have a Resource assigned to it using
WithResource()when creating the metric controller or the trace provider, the default Resource is used instead.Resolves #1391