Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility tests to CI #1567

Merged
merged 18 commits into from
Mar 1, 2021
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 22, 2021

Overall this aims to increase our CI testing coverage across different OS/ARCH pairs and reduce CI run time by parallelization of the jobs. The latter is somewhat negated by the fact that setup and tests on Windows take longer to run (meaning this is about the same in run time).

  • Run lint/build, race detector test, and coverage test CI jobs in parallel.
  • Add compatibility testing for the Windows and MacOS operating systems.
  • Fix CI cache key for Go modules.
  • Add cache for Go tools.
  • Unify testing targets in Makefile.
  • Add convenience variables for all the testing tools in the Makefile.
  • Update tools build targets.
    • Unify on build target and ensure the tools directory is present before build.
    • Add the crosslink tool target and use the built binary for testing.
    • Add the misspell target to run misspell, breaking it out of the lint target and having the new target be a dependency instead.
  • Increase testing timeout from 30 seconds to 60 to account for slower testing time on Windows systems.

Resolves #1523

MrAlias and others added 12 commits February 24, 2021 07:02
Some of the aggregator tests are running just over 30 seconds when
testing on Windows. Bump this to allow for it.
Having a unified job setup the cache when none exists so packages are
only downloaded once is ideal, but these steps are taking too long. In
some situations they are doubling the run time. Remove them and prefer
to have multiple downloads when dependencies change.
Unused now that the cache jobs are removed.
@MrAlias MrAlias marked this pull request as ready for review February 25, 2021 17:22
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrAlias MrAlias merged commit e25503a into open-telemetry:main Mar 1, 2021
@MrAlias MrAlias deleted the compatibility-test branch March 1, 2021 16:38
This was referenced Mar 11, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI and build tools
4 participants