Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename local var new to not collide with builtin #1610

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 26, 2021

No description provided.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 26, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #1610 (069360f) into main (13938ab) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1610   +/-   ##
=====================================
  Coverage   77.6%   77.7%           
=====================================
  Files        128     128           
  Lines       6637    6637           
=====================================
+ Hits        5155    5157    +2     
+ Misses      1235    1233    -2     
  Partials     247     247           
Impacted Files Coverage Δ
sdk/trace/provider.go 95.0% <100.0%> (ø)
exporters/otlp/otlpgrpc/connection.go 88.7% <0.0%> (+1.8%) ⬆️

@MrAlias MrAlias merged commit 841d2a5 into open-telemetry:main Mar 3, 2021
@MrAlias MrAlias deleted the rename-new-var branch March 3, 2021 16:26
ldelossa pushed a commit to ldelossa/opentelemetry-go that referenced this pull request Mar 5, 2021
* Rename local var new to not collide with builtin

* Add missed var rename
This was referenced Mar 7, 2021
This was referenced Mar 11, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants