Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter: export Link from SpanData in Jaeger exporter #165

Closed
rghetia opened this issue Oct 3, 2019 · 2 comments · Fixed by #173
Closed

Exporter: export Link from SpanData in Jaeger exporter #165

rghetia opened this issue Oct 3, 2019 · 2 comments · Fixed by #173
Labels
good first issue Good for newcomers
Milestone

Comments

@rghetia
Copy link
Contributor

rghetia commented Oct 3, 2019

Jaeger Exporter was added prior to Link support. Hence, Link is not exported via Jaeger exporter. See TODO

@rghetia rghetia added good first issue Good for newcomers exporters labels Oct 3, 2019
@rghetia rghetia added this to the Alpha v0.2 milestone Oct 3, 2019
@paivagustavo
Copy link
Member

Hi @rghetia!

I was playing with this issue but looks like the apitrace.Link structure does not have a "type of link" (seems like Jaeger accepts "child of" and "follows from") to map to Jaeger's SpanRefType.

So links are not getting exported even after uncomment the mentioned code. Hardcoding child_of works.

Should this be added to the api? Should we assume every link is a child_of relationship? Or is this not yet ready to be done?

@rghetia
Copy link
Contributor Author

rghetia commented Oct 4, 2019

@paivagustavo for now hardcode child_of and add a TODO pending resolution of the issue open-telemetry/opentelemetry-specification#65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants