Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: expose "default" propagators #312

Closed
iredelmeier opened this issue Nov 13, 2019 · 5 comments
Closed

Suggestion: expose "default" propagators #312

iredelmeier opened this issue Nov 13, 2019 · 5 comments
Labels
good first issue Good for newcomers
Milestone
Alpha v0.3 (Beta)

Comments

@iredelmeier
Copy link
Member

e.g., const DefaultTextFormatPropagator TextFormatPropagator = HTTPTraceContextPropagator (which I realize wouldn't technically compile due to lack of imports...)

This would help ensure consistency across plugins.
@jmacd
Copy link
Contributor

jmacd commented Nov 21, 2019

This is a request for an alias, "DefaultTextFormatPropagator" that's equal to the HTTP propagator. This helps clarify that B3 is not the default.

Could we name the HTTP propagator "W3CTraceContextPropagator"?

@iredelmeier
Copy link
Member Author

I think that renaming the HTTP propagator to W3CTraceContextPropagator would be worth doing, but is separate from the default.

@iredelmeier iredelmeier self-assigned this Nov 25, 2019
@iredelmeier
Copy link
Member Author

See #355 for the rename side of things.

@rghetia rghetia added the good first issue Good for newcomers label Dec 5, 2019
@iredelmeier iredelmeier removed their assignment Dec 5, 2019
@ptravers
Copy link

ptravers commented Dec 8, 2019 •
edited
Loading

Hey! Would you mind if I picked up this issue?

@clsung clsung mentioned this issue Jan 31, 2020
Merged
@rghetia rghetia added this to the Alpha v0.3 milestone Feb 13, 2020
@rghetia
Copy link
Contributor

rghetia commented Feb 27, 2020

will be fixed by #494

@rghetia rghetia closed this as completed Mar 12, 2020
hstan referenced this issue in hstan/opentelemetry-go Oct 15, 2020
@MrAlias
Ignore auth_test for 386 builds (#312)
e6529ec 
Temporary fix while #310 is addressed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
Alpha v0.3 (Beta)
Development

No branches or pull requests
4 participants
@ptravers @iredelmeier @jmacd @rghetia