Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature flagging semantic conventions #3696

Closed
jan-xyz opened this issue Feb 8, 2023 · 2 comments · Fixed by #3697
Closed

feature flagging semantic conventions #3696

jan-xyz opened this issue Feb 8, 2023 · 2 comments · Fixed by #3697
Labels
enhancement New feature or request
Milestone

Comments

@jan-xyz
Copy link

jan-xyz commented Feb 8, 2023

Problem Statement

With open-telemetry/opentelemetry-specification#2529 the semantic convention was extended with feature flag support but it's not available yet in the Go SDK.

Proposed Solution

Update to latest semantic convention spec.

Alternatives

It's possible to built it manually or use the OpenFeature SDK.

Prior Art

It is already added to the OpenFeature SDK in: https://github.com/open-feature/go-sdk-contrib/blob/main/hooks/open-telemetry/pkg/otel.go

Additional Context

I am opening this issue to understand better if this is something that belongs in here (as the specification is an Opentelemetry Spec) or if this should only exist in the OpenFeature SDK. We are currently working a lot with local feature flags and it seems a bit odd to import the OpenFeature SDK to properly add events to our spans.

@Aneurysm9
Copy link
Member

These seem to have been missed as they're type: event and we weren't processing that type. A quick check confirms there aren't any other types we're missing:

$ ack -h '^\s{4}type:\s+' | sort | uniq -c | sort
   4     type: event
  29     type: resource
  61     type: span

#3697 should fix that going forward. The feature_flag conventions were added in 1.16 but we've changed the generation of conventions a bit since then and if it's okay to have them from 1.17 forward that's going to be the most straightforward solution.

@jan-xyz
Copy link
Author

jan-xyz commented Feb 9, 2023

Thanks a lot! That was super fast! ❤️

@XSAM XSAM added this to the untracked milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants