You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am opening this issue to understand better if this is something that belongs in here (as the specification is an Opentelemetry Spec) or if this should only exist in the OpenFeature SDK. We are currently working a lot with local feature flags and it seems a bit odd to import the OpenFeature SDK to properly add events to our spans.
The text was updated successfully, but these errors were encountered:
These seem to have been missed as they're type: event and we weren't processing that type. A quick check confirms there aren't any other types we're missing:
#3697 should fix that going forward. The feature_flag conventions were added in 1.16 but we've changed the generation of conventions a bit since then and if it's okay to have them from 1.17 forward that's going to be the most straightforward solution.
Problem Statement
With open-telemetry/opentelemetry-specification#2529 the semantic convention was extended with feature flag support but it's not available yet in the Go SDK.
Proposed Solution
Update to latest semantic convention spec.
Alternatives
It's possible to built it manually or use the OpenFeature SDK.
Prior Art
It is already added to the OpenFeature SDK in: https://github.com/open-feature/go-sdk-contrib/blob/main/hooks/open-telemetry/pkg/otel.go
Additional Context
I am opening this issue to understand better if this is something that belongs in here (as the specification is an Opentelemetry Spec) or if this should only exist in the OpenFeature SDK. We are currently working a lot with local feature flags and it seems a bit odd to import the OpenFeature SDK to properly add events to our spans.
The text was updated successfully, but these errors were encountered: