-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Span.ModifyAttributes() #53
Comments
I created the prototype using OpenCensus for inspiration, so that's where this came from, and the initial prototype in this repository was a streaming implementation. These The reader of the stream is responsible for reconstructing Span attributes at each point in the stream. Modify operations are simply applied by the reader to update the attribute state at subsequent points in the stream. This raises questions, like how is a user to un-set an attribute? How is a user to delete an attribute? How will the OpenCensus libraries handle this transition? @bogdandrutu ^^^ more of a spec question than a Golang question. |
@jmacd what is the use case for deleting / unsetting an attribute? Such functionality did not exist in OpenTracing, and nobody asked for it, iirc. |
The I feel that OpenTracing didn't specify this well enough. I imagine we could find uses of I don't think this is a big deal, and I'm more than happy to remove |
Hey @jmacd I would like to work on this, I am new to tracing and would like to contribute to
In trace package
but I don't see any method definition in trace package it's an empty function. I see this in multiple places. So the scope of this issue is to remove it from all the places? |
Yes. In the prototype, this pattern of supporting Mutators was carried over from the OpenCensus code base. We'll remove it, which means any Mutator should disappear. All |
* Update datadog/dogstatsd to use otel v0.6.0. Moving forward with a newer version of datadog-go requires a PR to be merged that will enforce 8-byte aligned atomics for 386 (32 bit) architectures. (This guarantee was removed in datadog-go v3.6.0) See DataDog/datadog-go#152 * Update all to go.opentelemetry.io/otel v0.6.0 * fixup! Update datadog/dogstatsd to use otel v0.6.0.
Supporting this kind of method requires holding onto the span in memory and prevents streaming implementation. There is no such method in the Java API.
The text was updated successfully, but these errors were encountered: