Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rv not set in tracestate for consistent56 sampling #1468

Open
anuragagarwal561994 opened this issue Sep 21, 2024 · 0 comments
Open

rv not set in tracestate for consistent56 sampling #1468

anuragagarwal561994 opened this issue Sep 21, 2024 · 0 comments

Comments

@anuragagarwal561994
Copy link

Component(s)

samplers

What happened?

Description

rv value is not set in the tracestate

Steps to Reproduce

use consistent56 sampling for your traces

Expected Result

rv should be set and passed in the tracestate but it is not

Actual Result

rv value is not passed

Component version

1.39.0-alpha

Log output

Request headers : {"Traceparent": "00-55bc3cfaa3eeeafcd2c03a7f68b83799-cc5a2666503c8e6b-01", "Tracestate": "ot=th:8"}

Additional context

I also wanted to understand even if the trace is not sampled if the rv should be passed to the subsequent system, may be the distributed system might want to be able to use this rv value to may be sample at its end.

So for example may be the sampling percentage for the trace in the current system is 1% but the next system it is 5%, so shouldn't rv be passed ahead so that the other system doesn't need to compute the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant