Replies: 1 comment 1 reply
-
Historically, Jaeger samplers only had access to trace id and operation name. In Go and Node.js they have access to the full span and start/finish/setTag life cycle events. They theoretically do have access to Span References, but we never had a use case for that. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently, our jaeger remote sampler looks at links in the rate limiting sampler
https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/RateLimitingSampler.java#L65
It doesn't for the probabilistic sampler. I don't think it does upstream either
https://github.com/jaegertracing/jaeger-client-java/blob/master/jaeger-core/src/main/java/io/jaegertracing/internal/samplers/RateLimitingSampler.java#L49
So I suspect it's ok to remove this
Link
-based sampling to clean things up a bit - @yurishkuro can you confirm?Beta Was this translation helpful? Give feedback.
All reactions