Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill service.instance.id with UUID by default #1726

Closed
anuraaga opened this issue Sep 29, 2020 · 3 comments
Closed

Fill service.instance.id with UUID by default #1726

anuraaga opened this issue Sep 29, 2020 · 3 comments
Labels
Feature Request Suggest an idea for this project

Comments

@anuraaga
Copy link
Contributor

A user, or other resource provider, may specify a better service.instance.id, but by default we should add a UUID as recommended by the spec.

https://github.com/open-telemetry/opentelemetry-specification/tree/master/specification/resource/semantic_conventions#service

@anuraaga anuraaga added the Feature Request Suggest an idea for this project label Sep 29, 2020
@jkwatson
Copy link
Contributor

jkwatson commented Mar 5, 2021

If the spec were updated to make this field mandatory (which I know has been discussed), then this seems like it would be an important fallback to add to Resource.getDefault(). For the nonce, I don't think we should do this without the spec making it required.

Do you think this is something that one of the resource auto-detectors should provide?

@jkwatson
Copy link
Contributor

Do you think this is something that one of the resource auto-detectors should provide?

ping @anuraaga

@anuraaga
Copy link
Contributor Author

It's been a while since I filed open-telemetry/opentelemetry-specification#1034 (comment) about not understanding this attribute. I think it's still not a good attribute, for the reason @Oberon00 mentions too :) So will just close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

2 participants