Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary Metric Support #4094

Open
cpheps opened this issue Jan 18, 2022 · 7 comments
Open

Summary Metric Support #4094

cpheps opened this issue Jan 18, 2022 · 7 comments
Labels
blocked:spec blocked on open or unresolved spec Feature Request Suggest an idea for this project metrics

Comments

@cpheps
Copy link

cpheps commented Jan 18, 2022

Is your feature request related to a problem? Please describe.

Add support for Legacy Summary metric type. This metric type is listed as use for legacy systems and not recommended for use in new receivers. That being said a lot of older (legacy) Java JMX systems have metrics that fit the Summary metric model.

Apache HBase is such a system. Particularly the ops metrics:

hbase.regionserver.<op>_<measure>
Operation latencies, where is one of Append, Delete, Mutate, Get, Replay, Increment; and where is one of min, max, mean, median, 75th_percentile, 95th_percentile, 99th_percentile

Describe the solution you'd like
Add support for the summary metric type.

Describe alternatives you've considered
Capture each part of the summary metric as its own metric.

Additional context
I see this was discussed in issue #4075 but after some discussion with @jsuereth we felt it was worth readdressing the need for this. He might be able to more context also.

@cpheps cpheps added the Feature Request Suggest an idea for this project label Jan 18, 2022
@jkwatson
Copy link
Contributor

Before we would do anything for this, the metrics specification would need to support it. We won't add new features to the API without it being spec approved.

@jsuereth
Copy link
Contributor

@jkwatson One thing I want to mention is that I think the legacy use case here (adapting JMX -> OTel), should that be something the API supports or not?

Specifically:

  • We don't want to encourage users to use Summary for new metrics, so we don't want to expose it in the API
  • Is adapting JMX -> OTel really an API concern? Should we expose an SDK-extension or hook that allows this use case?

While I've been AFK due to personal reasons, I'd still like to see if we can use this issue to "open" an adapter-like interface for advanced use cases like interfacing with existing metric systems via instrumentation.

Agree this needs a specification discussion. IS there a way we could toy with an SDK-extension to lead that discussion?

@jkwatson
Copy link
Contributor

If this could be accomplished with an SDK extension, I'd definitely be in favor of someone submitting a PR for that.

@asafm
Copy link
Contributor

asafm commented Jul 26, 2022

Seems that Summary is defined in the OT spec as can be seen here and here.

Given that, is it possible to contribute code to support it?

@jkwatson
Copy link
Contributor

Seems that Summary is defined in the OT spec as can be seen here and here.

Given that, is it possible to contribute code to support it?

That is the datamodel, not the API spec. We'd need it to be in the API spec before we would support it as a part of our APIs.

@yingziisme
Copy link

so any schedule for summary api?

@jkwatson jkwatson added the blocked:spec blocked on open or unresolved spec label Oct 7, 2022
@jkwatson
Copy link
Contributor

jkwatson commented Oct 7, 2022

so any schedule for summary api?

no. Since this isn't a part of the standard spec, we're probably not going to build it until it becomes part of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked:spec blocked on open or unresolved spec Feature Request Suggest an idea for this project metrics
Projects
None yet
Development

No branches or pull requests

5 participants