-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider changing help text for span/logs batch exporter metric "queueSize" #4834
Comments
This seems reasonable. However, like opentelemetry-specification#2703 aims to solve instrument name collisions across different scopes, I think we will ultimately need a solution at the spec level. |
We are running into this issue with the OpenTelemetry Demo project. The adservice in that project, a Java-based app, has the auto-instrumentation agent enabled to send all data to an OpenTelemetry collector. The Ideally, we shouldn't have to do this, and the SDK would work without any special configuration required within the Collector itself. This could also be an opportunity to converge that metric to standard attribute names and descriptions across all telemetry types. Based on the telemetry type, it currently emits |
Not sure if I am seeing a regression here. The otel-collectors are complaining about metrics and logs received from Java services using the java-agent. None of the non-java services cause this error.
Agent: v1.32.1 and v2.0.0 I'll create a new issue if needed. |
Is your feature request related to a problem? Please describe.
Currently, sending logs and spans over OTLP from a Java application using the BatchSpanProcessor and BatchLogRecordProcessor causes problems for the OpenTelemetry collector when configured with a Prometheus exporter.
While this seems like a limitation of the Prometheus exposition format, even after including the InstrumentationScope name/version as attributes on each of these
queueSize
metrics, most Prometheus exporters (certainly the Golang one does) will complain that it has two metrics with the same name but different "help" text.In the Java SDK case, the log record batch processor creates a
queueSize
metric with description "The number of logs queued" while the span batch processor creates aqueueSize
metric with description "The number of spans queued".Describe the solution you'd like
Consider changing the description, aka "help" text, for each to be "The number of items queued". Since each one has a different InstrumentationScope as well as a different attribute (
spanProcessorType
vs.logRecordProcessorType
), these will still be distinguishable in the backend.Describe alternatives you've considered
Use
transformprocessor
to "delete" the metric "description" field from metrics destined for Prometheus exporter (seems drastic).Additional context
OpenTelemetry Specification PR for InstrumentationScope labels: open-telemetry/opentelemetry-specification#2703
The text was updated successfully, but these errors were encountered: