-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update Azure Functions Detector Collected Attributes #2233
Merged
pichlermarc
merged 8 commits into
open-telemetry:main
from
JacksonWeber:jacksonweber/update-functions-detector
May 31, 2024
Merged
fix: Update Azure Functions Detector Collected Attributes #2233
pichlermarc
merged 8 commits into
open-telemetry:main
from
JacksonWeber:jacksonweber/update-functions-detector
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2233 +/- ##
==========================================
- Coverage 90.97% 90.40% -0.58%
==========================================
Files 146 149 +3
Lines 7492 7514 +22
Branches 1502 1573 +71
==========================================
- Hits 6816 6793 -23
- Misses 676 721 +45
|
blumamir
reviewed
May 23, 2024
detectors/node/opentelemetry-resource-detector-azure/src/detectors/AzureFunctionsDetector.ts
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-azure/src/detectors/AzureFunctionsDetector.ts
Show resolved
Hide resolved
blumamir
approved these changes
May 30, 2024
hectorhdzg
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes
faas.name
and properly populatesservice.name
instead for example. We also now collect the process PID and cloud resource ID.