Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: semconv alignment & listed in README #2240

Merged
merged 4 commits into from
May 30, 2024
Merged

fix: semconv alignment & listed in README #2240

merged 4 commits into from
May 30, 2024

Conversation

Netail
Copy link
Contributor

@Netail Netail commented May 24, 2024

Summary

  • Align with correct semantic conventions
  • Document exported attributes

@Netail Netail requested a review from a team May 24, 2024 23:30
@github-actions github-actions bot requested a review from legendecas May 24, 2024 23:30
@Netail Netail mentioned this pull request May 24, 2024
Merged
legendecas
legendecas reviewed May 29, 2024
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM once lint complaints are fixed.

@legendecas legendecas merged commit 040eaa6 into open-telemetry:main May 30, 2024
17 checks passed
@dyladan dyladan mentioned this pull request May 30, 2024
Merged
@Netail Netail deleted the fix/semconv-alignment branch May 30, 2024 16:11
@sjvans sjvans mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

Assignees

@legendecas legendecas

Labels
pkg:host-metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Netail @legendecas