fix(instr-express): fix handler patching for already patched router

[david-luna]

Which problem is this PR solving?

• closes Express instrumentation results in routes with no stack, crashing Ghost #2271

Short description of the changes

• use for...in to iterate over all the enumerable properties of the handler (own properties and inherited)
• add a test with the same scenario described in Express instrumentation results in routes with no stack, crashing Ghost #2271

I finally opted to use the for...in statement instead of the Proxy. I ran some benchmarks following this article and the results in node v18.16.0 were

% node index.js

vanilla x 1,107,664,482 ops/sec ±0.21% (101 runs sampled)
proxy x 3,842,562 ops/sec ±0.34% (75 runs sampled)
defineProperty x 1,108,137,480 ops/sec ±0.25% (101 runs sampled)
Fastest is defineProperty,vanilla

Since any middleware can access the handler properties I think there could be use cases where those properties are accessed frequently so I preferred the for...in + defineProperty approach. The only drawback is non enumerable props are not accessible but I think for now it's fine

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (dfb2dff) to head (db19a98).
Report is 184 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
- Coverage   90.97%   90.42%   -0.56%     
==========================================
  Files         146      148       +2     
  Lines        7492     7322     -170     
  Branches     1502     1518      +16     
==========================================
- Hits         6816     6621     -195     
- Misses        676      701      +25     

Files	Coverage Δ
...try-instrumentation-express/src/instrumentation.ts	98.61% <100.00%> (-1.39%)	⬇️

... and 61 files with indirect coverage changes

[Zirak]

Thank you! I've done the patch locally and tested with Ghost, things are working swimmingly.

[david-luna]

Fixed the lint issue. Ready for review @JamieDanielson @pkanal

[JamieDanielson]

Thanks for this @david-luna ! Also appreciate the new test and detail in the comments.