Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align status with proto #1850

Closed
obecny opened this issue Jan 20, 2021 · 0 comments · Fixed by #1860
Closed

Align status with proto #1850

obecny opened this issue Jan 20, 2021 · 0 comments · Fixed by #1860
Assignees
@obecny
Labels
bug Something isn't working

Comments

@obecny
Copy link
Member

obecny commented Jan 20, 2021

https://github.com/open-telemetry/opentelemetry-proto/blob/master/opentelemetry/proto/trace/v1/trace.proto#L304
Currently span status is
0 - OK
1 - Unset
2 - Error

Proto defines this as
0 - Unset
1 - OK
2 - Error

During export in Exporter Collector the status is being converted. But this might cause an error in any other exporters etc. and I think we should align this so the status is the same across all different packages.
@obecny obecny added the bug Something isn't working label Jan 20, 2021
@obecny obecny self-assigned this Jan 20, 2021
@obecny obecny mentioned this issue Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obecny obecny

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fixing status code aligning it with proto obecny/opentelemetry-js
1 participant
@obecny