Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a delegating no-op LoggerProvider #4399

Closed
hectorhdzg opened this issue Jan 3, 2024 · 3 comments · Fixed by #4861
Closed

Implement a delegating no-op LoggerProvider #4399

hectorhdzg opened this issue Jan 3, 2024 · 3 comments · Fixed by #4861
Assignees
@hectorhdzg
Labels
api:logs Issues and PRs related to the Logs API feature-request never-stale
Milestone
Logs API/SDK GA

Comments

@hectorhdzg
Copy link
Member

Is your feature request related to a problem? Please describe
Currently when a LoggerProvider is registered via logs.setGlobalLoggerProvider() after acquiring a logs.getLoggerProvider() elsewhere, the previously acquired LoggerProvider will stay no-op forever unless replaced manually.

Describe the solution you'd like to see
Implementing the same delegating-noop similar to the one in the trace API, where a ProxyTracerProvider and ProxyTracer delegate calls to either the registered SDK instance or a NoopTracerProvider or NoopTracer.

Additional context
Related to #3622
@hectorhdzg hectorhdzg added feature-request api:logs Issues and PRs related to the Logs API labels Jan 3, 2024
@dyladan
Copy link
Member

dyladan commented Jan 5, 2024

Seems like a pretty straightforward win and usability improvement to me

@hectorhdzg hectorhdzg added this to the Logs API/SDK GA milestone Jan 10, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Mar 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
@pichlermarc pichlermarc removed the stale label Apr 29, 2024
@pichlermarc pichlermarc reopened this Apr 29, 2024
@pichlermarc pichlermarc mentioned this issue Apr 30, 2024
Merged
4 tasks
@hectorhdzg hectorhdzg mentioned this issue Jul 11, 2024
Merged
3 tasks
@hectorhdzg hectorhdzg self-assigned this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hectorhdzg hectorhdzg

Labels
api:logs Issues and PRs related to the Logs API feature-request never-stale
Projects
None yet
Milestone
Logs API/SDK GA
Development

Successfully merging a pull request may close this issue.

feat(api-logs): Add delegating no-op logger provider hectorhdzg/opentelemetry-js
3 participants
@dyladan @pichlermarc @hectorhdzg