From fcfe8801a9951b99db2e4970a12a5c4178192e61 Mon Sep 17 00:00:00 2001 From: Zen-cronic <83657429+Zen-cronic@users.noreply.github.com> Date: Tue, 4 Jun 2024 09:48:52 -0400 Subject: [PATCH 1/3] refactor(examples/opentracing-shim): use new exported string constants for semconv --- examples/opentracing-shim/shim.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/opentracing-shim/shim.js b/examples/opentracing-shim/shim.js index fe6771ced4..0f791071ee 100644 --- a/examples/opentracing-shim/shim.js +++ b/examples/opentracing-shim/shim.js @@ -1,6 +1,6 @@ 'use strict'; -const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions'); +const { SEMRESATTRS_SERVICE_NAME } = require('@opentelemetry/semantic-conventions'); const { Resource } = require('@opentelemetry/resources'); const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node'); const { SimpleSpanProcessor } = require('@opentelemetry/sdk-trace-base'); @@ -10,7 +10,7 @@ const { TracerShim } = require('@opentelemetry/shim-opentracing'); function shim(serviceName) { const provider = new NodeTracerProvider({ - resource: new Resource({ [SemanticResourceAttributes.SERVICE_NAME]: serviceName }), + resource: new Resource({ [SEMRESATTRS_SERVICE_NAME]: serviceName }), }); provider.addSpanProcessor(new SimpleSpanProcessor(getExporter(serviceName))); From 5e8e9f92d21a00ca034aff1ef2f2c312cadc730c Mon Sep 17 00:00:00 2001 From: Zen-cronic <83657429+Zen-cronic@users.noreply.github.com> Date: Tue, 4 Jun 2024 10:55:59 -0400 Subject: [PATCH 2/3] updated semconv to ^1.22.0 --- examples/opentracing-shim/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/opentracing-shim/package.json b/examples/opentracing-shim/package.json index 37cc5ab31d..598c9b4762 100644 --- a/examples/opentracing-shim/package.json +++ b/examples/opentracing-shim/package.json @@ -36,7 +36,7 @@ "@opentelemetry/instrumentation": "0.25.0", "@opentelemetry/sdk-trace-node": "0.25.0", "@opentelemetry/resources": "0.25.0", - "@opentelemetry/semantic-conventions": "0.25.0", + "@opentelemetry/semantic-conventions": "^1.22.0", "@opentelemetry/shim-opentracing": "0.25.0", "@opentelemetry/sdk-trace-base": "0.25.0", "opentracing": "^0.14.4" From 76ba0490c3c1848e6db81c5a5d85190559e92fd1 Mon Sep 17 00:00:00 2001 From: Zen-cronic <83657429+Zen-cronic@users.noreply.github.com> Date: Tue, 4 Jun 2024 10:57:52 -0400 Subject: [PATCH 3/3] added changelog entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d6e31bc077..6ca803912a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/ ### :books: (Refine Doc) * refactor(examples): use new exported string constants for semconv in examples/http [#4750](https://github.com/open-telemetry/opentelemetry-js/pull/4750) @Zen-cronic +* refactor(examples): use new exported string constants for semconv in examples/opentracing-shim-semconv [#4761](https://github.com/open-telemetry/opentelemetry-js/pull/4761) @Zen-cronic ### :house: (Internal)