Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to rename "instrumentation library" to "instrumentation scope"? #504

Closed
Tracked by #2203
tigrannajaryan opened this issue Dec 6, 2021 · 3 comments

Comments

@tigrannajaryan
Copy link
Member

This initially came from a discussion about introducing Logger Name.

While discussing the issue during the spec SIG meeting we came to a conclusion that the intent for "instrumentation library" was actually to have an "instrumentation scope".

The "instrumentation library" is currently used throughout the spec API and SDK. We want to explore if it is possible to rename "instrumentation library" to "instrumentation scope" without breaking existing stability guarantees.

This issue is a questions for the maintainers of this repo: are we able to do this in a non-breaking manner?

Note: this should be only done if it is not a breaking change. We must continue honouring our stability guarantees.

Warning: please don't make the actual change yet. We need to confirm first that it is possible to make this change everywhere before moving forward.

Spec issue recorded here: open-telemetry/opentelemetry-specification#2203

@tigrannajaryan
Copy link
Member Author

It appears the conclusion of many SDKs is that this is not a possible change. Closing.

@tidal
Copy link
Member

tidal commented Dec 7, 2021

@tigrannajaryan
Ok, FWIW, we wanted to discuss this in our meeting at Wednesday, but it should not have been a problem for us, and a 1 minute task with suitable refactoring tools.

@tigrannajaryan
Copy link
Member Author

@tidal Thanks for checking. This change is not possible in other SDKs and we need it everywhere or nowhere, so we are forced to back off and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants