Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psycopg2-binary dependency conflict #541

Open
RyanSiu1995 opened this issue Jun 11, 2021 · 5 comments · Fixed by #543
Open

psycopg2-binary dependency conflict #541

RyanSiu1995 opened this issue Jun 11, 2021 · 5 comments · Fixed by #543
Labels

Comments

@RyanSiu1995
Copy link
Contributor

Describe your environment

> pip freeze | grep psyco
opentelemetry-instrumentation-psycopg2==0.22b0
psycopg2==2.8.6

Steps to reproduce
Install psycopg2 instead of psycopg2-binary

What is the expected behavior?
No error message popping up

What is the actual behavior?
The instrumentation library will throw this error for every run.

DependencyConflict: requested: "psycopg2-binary >= 2.7.3.1" but found: "None"

Additional context
The instrumentation actually works as expected for psycopg2. So, the package instrumented should be both psycopg2-binary and psycopg

@RyanSiu1995 RyanSiu1995 added the bug Something isn't working label Jun 11, 2021
@cdvv7788
Copy link
Contributor

psycopg-binary is not recommended for production usage. It should not be used as a dependency in general. It is more of a workaround for local setups.

@owais
Copy link
Contributor

owais commented Apr 12, 2022

Since this was closed, we've reworked how we handle instrumentation <> library dependencies and I think it should be possible to support both with the same instrumentation. Would be great if someone could experiment and figure out if it is doable easily.

@owais owais added good first issue Good for newcomers help wanted Extra attention is needed feature-request auto-instrumentation and removed bug Something isn't working labels Apr 12, 2022
@cdvv7788
Copy link
Contributor

I can give it a try this weekend. However note that the package discourages the usage of psycopg-binary for anything that is not testing https://pypi.org/project/psycopg2-binary/

@owais
Copy link
Contributor

owais commented Apr 12, 2022

Agree but if we can easily support both, we can make life easier for people using binary in dev/CI while still using opentelemetry.

@srikanthccv
Copy link
Member

relevant discussion and some proposal here #610.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants