Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore prometheus remote write exporter #933

Closed
codeboten opened this issue Feb 28, 2022 · 7 comments · Fixed by #1359
Closed

Restore prometheus remote write exporter #933

codeboten opened this issue Feb 28, 2022 · 7 comments · Fixed by #1359
Assignees
Labels
exporter feature-request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@codeboten
Copy link
Contributor

This issue tracks the work to restore the prometheus remote write exporter. It is a follow up to issue open-telemetry/opentelemetry-python#2291 which restores the prometheus exporter in the core repo.

@codeboten codeboten added good first issue Good for newcomers help wanted Extra attention is needed feature-request exporter labels Feb 28, 2022
@Doron-Bargo
Copy link

Hi @codeboten any update on restoring the Prometheus remote write exporter?
I notice it exists under metrics branch but never pushed to the main.

@vasireddy99
Copy link
Contributor

vasireddy99 commented May 31, 2022

Looks like we now have Prometheus exporter in the main branch.

@lzchen
Copy link
Contributor

lzchen commented May 31, 2022

@vasireddy99

The current prometheus exporter that you are linking to is the pull-based prometheus exporter. We have yet to implement the remote-write exporter in the main branch using the updated metrics api/sdks.

@codeboten
Copy link
Contributor Author

The current exporter that @vasireddy99 linked is the pull based exporter, @Doron-Bargo no one has taken on the work to bring back the remote write exporter. Would love help here if anyone has time for it

@haarakdy
Copy link

haarakdy commented Jul 4, 2022

@codeboten what is the difference between prometheus remote write exporter and the exporter I use currently 0.17b0 ?
The exporter I use, the class PrometheusRemoteWriteMetricsExporter, pushes the data to the Logz.io and relies on gRPC.
Will this issue address #1142 performance depends on the amount of unique (label, value) tuples ?

@srikanthccv
Copy link
Member

What you are using is based on the old API&SDK design which is no longer supported. There have been some significant changes since then and this issue is to restore the exporter to make it work with new API.

@Seefooo
Copy link
Contributor

Seefooo commented Aug 8, 2022

I think I can do this one. Going to take me a bit of time though as its my first OS contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter feature-request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants