Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split logging functionality into API and SDK like other signals #3134

Closed
Tracked by #2911
tigrannajaryan opened this issue Jan 19, 2023 · 5 comments
Closed
Tracked by #2911
Assignees

Comments

@tigrannajaryan
Copy link
Member

The Log specification recently went through a series of modifications, the result of which is that now we have Log API and Log SDK specification, similar to the separation we have for traces and metrics.

Please refactor the Python's experimental implementation to match the specification, if it is not already.

@tigrannajaryan
Copy link
Member Author

cc @open-telemetry/specs-logs-approvers

@srikanthccv
Copy link
Member

@lzchen I believe we already completed this except for the proxies, which is a Python SDK thing to work around specific early access issues. Is there anything pending I missed?

@tigrannajaryan
Copy link
Member Author

I believe we already completed this except for the proxies

This is great.

I checked the example and I think it is using LoggerProvider from the SDK. Perhaps it can be updated to show obtaining the global LoggerProvider from the API, similar to how it obtains the global TracerProvider?

@srikanthccv
Copy link
Member

Sure, we'll update that.

@tigrannajaryan
Copy link
Member Author

I am closing this issue since splitting into API and SDK is done. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants