Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated module not found #4020

Closed
king-11 opened this issue Jul 3, 2024 · 3 comments · Fixed by #4046
Closed

deprecated module not found #4020

king-11 opened this issue Jul 3, 2024 · 3 comments · Fixed by #4046
Labels
bug Something isn't working good first issue Good first issue

Comments

@king-11
Copy link
Contributor

king-11 commented Jul 3, 2024

Describe your environment

OS: Windows
Python version: 3.9.7
SDK version: 1.25.0
API version: 1.25.0

What happened?

Lib\site-packages\opentelemetry\trace\__init__.py:84: in <module>
    from deprecated import deprecated
E   ModuleNotFoundError: No module named 'deprecated'

Steps to Reproduce

  • create a new project
  • setup env var
  • run poetry add opentelemetry-api

Expected Result

deprecated and importlib-metadata should show up in poetry.lock file as dependencies

Actual Result

no dependencies shown for opentelemetry-api

Additional context

No response

Would you like to implement a fix?

Yes

@king-11 king-11 added the bug Something isn't working label Jul 3, 2024
@xrmx xrmx added the good first issue Good first issue label Jul 11, 2024
@xrmx
Copy link
Contributor

xrmx commented Jul 11, 2024

opentelemetry-api correctly lists them as dependencies:

dependencies = [
    "Deprecated >= 1.2.6",
    # FIXME This should be able to be removed after 3.12 is released if there is a reliable API
    # in importlib.metadata.
    "importlib-metadata >= 6.0, <= 8.0.0",
]

@xrmx
Copy link
Contributor

xrmx commented Jul 11, 2024

I think the only package that use deprecated but does not have it as direct dependency is opentelemetry-semantic-conventions and that should probably be fixed

@king-11
Copy link
Contributor Author

king-11 commented Jul 11, 2024

Thanks I have created a PR for the same will try upgrading my versions and see might be an issue with poetry itself not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants