Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add wrap / unwrap helpers into an instrumentation helper library? #667

Closed
toumorokoshi opened this issue May 11, 2020 · 1 comment · Fixed by #741
Closed

add wrap / unwrap helpers into an instrumentation helper library? #667

toumorokoshi opened this issue May 11, 2020 · 1 comment · Fixed by #741

Comments

@toumorokoshi
Copy link
Member

We have a lot of instrumentations now that adhere to the BaseInstrumentor, and this pattern of wrapping functions with wrapt and unwrapping are quite common now:

https://github.com/open-telemetry/opentelemetry-python/pull/643/files#diff-4ac826b7b2b5271928612cf6d60c20aeR118

Should we be investing in a helper library to unwrap this? or maybe contribute upstream?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@toumorokoshi @mauriciovasquezbernal