From fd9be6f0e5e12dc56f3f236d54cdf09924168fdd Mon Sep 17 00:00:00 2001
From: Trask Stalnaker <trask.stalnaker@gmail.com>
Date: Wed, 30 Mar 2022 15:21:53 -0700
Subject: [PATCH] Add rpc.system value for Apache Dubbo (#2453)

* Add rpc.system value for Apache Dubbo

* Generate table
---
 CHANGELOG.md                                      | 2 ++
 semantic_conventions/trace/rpc.yaml               | 3 +++
 specification/metrics/semantic_conventions/rpc.md | 1 +
 specification/trace/semantic_conventions/rpc.md   | 1 +
 4 files changed, 7 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index dd2eb3f7f58..a78dd0ced47 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -68,6 +68,8 @@ release.
   ([#1978](https://github.com/open-telemetry/opentelemetry-specification/pull/1978))
 - Add `process.cpu.utilization` metric.
   ([#2436](https://github.com/open-telemetry/opentelemetry-specification/pull/2436))
+- Add `rpc.system` value for Apache Dubbo.
+  ([#2453](https://github.com/open-telemetry/opentelemetry-specification/pull/2453))
 
 ### Compatibility
 
diff --git a/semantic_conventions/trace/rpc.yaml b/semantic_conventions/trace/rpc.yaml
index f87b5b29e53..003646e0447 100644
--- a/semantic_conventions/trace/rpc.yaml
+++ b/semantic_conventions/trace/rpc.yaml
@@ -19,6 +19,9 @@ groups:
             - id: dotnet_wcf
               value: 'dotnet_wcf'
               brief: '.NET WCF'
+            - id: apache_dubbo
+              value: 'apache_dubbo'
+              brief: 'Apache Dubbo'
       - id: service
         type: string
         required:
diff --git a/specification/metrics/semantic_conventions/rpc.md b/specification/metrics/semantic_conventions/rpc.md
index bcfdab38958..02a45f84a75 100644
--- a/specification/metrics/semantic_conventions/rpc.md
+++ b/specification/metrics/semantic_conventions/rpc.md
@@ -84,6 +84,7 @@ or not they should be on the server, client or both.
 | `grpc` | gRPC |
 | `java_rmi` | Java RMI |
 | `dotnet_wcf` | .NET WCF |
+| `apache_dubbo` | Apache Dubbo |
 <!-- endsemconv -->
 
 To avoid high cardinality, implementations should prefer the most stable of `net.peer.name` or
diff --git a/specification/trace/semantic_conventions/rpc.md b/specification/trace/semantic_conventions/rpc.md
index 1f99f6d0050..b1b322aa9e3 100644
--- a/specification/trace/semantic_conventions/rpc.md
+++ b/specification/trace/semantic_conventions/rpc.md
@@ -80,6 +80,7 @@ Examples of span names:
 | `grpc` | gRPC |
 | `java_rmi` | Java RMI |
 | `dotnet_wcf` | .NET WCF |
+| `apache_dubbo` | Apache Dubbo |
 <!-- endsemconv -->
 
 For client-side spans `net.peer.port` is required if the connection is IP-based and the port is available (it describes the server port they are connecting to).