Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilizing service.name #1497

Closed
anuraaga opened this issue Mar 3, 2021 · 6 comments
Closed

Stabilizing service.name #1497

anuraaga opened this issue Mar 3, 2021 · 6 comments
Labels
area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Mar 3, 2021

Currently all attributes are experimental, for example we see the Experimental label.

https://www.github.com/open-telemetry/opentelemetry-specification/tree/main/specification%2Fresource%2Fsemantic_conventions%2FREADME.md

But service.name is required to use Zipkin or Jaeger - those exporters are also effectively experimental because of this dependency. Is it possible to mark this attribute stable? I guess we should add support to the yaml generator for stable attributes if so.

@anuraaga anuraaga added the spec:resource Related to the specification/resource directory label Mar 3, 2021
@anuraaga
Copy link
Contributor Author

anuraaga commented Mar 3, 2021

For reference this came up because we don't have a stable way for configuring the service name in Java

open-telemetry/opentelemetry-java#2973

@Oberon00
Copy link
Member

Oberon00 commented Mar 3, 2021

👍 for making it stable. But we should consider it together with service.namespace, as they are closely related. The instance ID stuff should not be made stable yet though, see #1034.

@Oberon00 Oberon00 added the area:semantic-conventions Related to semantic conventions label Mar 3, 2021
@rakyll
Copy link
Contributor

rakyll commented Mar 5, 2021

+1 to considering to stabilize the name with namespace. We are thinking about representing service identifiers as a first-class thing in the backends. We should think about the service identity as namespace + name.

@anuraaga
Copy link
Contributor Author

anuraaga commented Mar 6, 2021

@thisthat Is this something we can add to the yaml tool?

@thisthat
Copy link
Member

@anuraaga sorry for the late reply! Sure, this can be added to the tool! Currently, we support only deprecated attributes. It would be easy to add other markers!

@jsuereth
Copy link
Contributor

Fixed by #3202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory
Development

No branches or pull requests

5 participants