Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusing limit on unit size #1746

Closed
jba opened this issue Jun 7, 2021 · 0 comments · Fixed by #1762
Closed

confusing limit on unit size #1746

jba opened this issue Jun 7, 2021 · 0 comments · Fixed by #1762
Assignees
Labels
area:api Cross language API specification issue spec:metrics Related to the specification/metrics directory

Comments

@jba
Copy link

jba commented Jun 7, 2021

The spec says that a unit string "can have a maximum length of 63 characters. The number 63 is chosen to allow the unit strings (including the \0 terminator on certain language runtimes) to be stored and compared as 8-bytes integers when performance is critical."

You can only fit 8 (ASCII) characters into 8 bytes, so I'm not sure what the intent here is (eight 8-byte integers?), or if this is just a mistake.

Also, I see elsewhere (#705) that units should follow the UCUM standard, but I don't see any length restrictions there.

@jba jba added the spec:metrics Related to the specification/metrics directory label Jun 7, 2021
@carlosalberto carlosalberto added the area:api Cross language API specification issue label Jun 7, 2021
@reyang reyang self-assigned this Jun 15, 2021
@reyang reyang added this to the Metrics API/SDK Feature Freeze milestone Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Cross language API specification issue spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants