Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Semantic Conventions] Http metric semantic conventions don't use semantic convention for defining units. #2186

Closed
jsuereth opened this issue Dec 2, 2021 · 1 comment · Fixed by #2199
Assignees
Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory

Comments

@jsuereth
Copy link
Contributor

jsuereth commented Dec 2, 2021

HTTP semantic conventions define units like "microseconds". According to this, the unit needs to be on ucum

@jsuereth jsuereth added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory labels Dec 2, 2021
@pichlermarc
Copy link
Member

pichlermarc commented Dec 3, 2021

This seems to be related to #705 and #1794.

The same seems to be the case for

while System Metrics Semantic Conventions seem to do it as the General Metric Semantic Conventions suggest.

It seems like changing this in the conventions I listed above would just be an editorial change. I'd be interested in picking this up.

Edit: typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants