Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more semantic convention attributes of Apache RocketMQ #2880

Closed
aaron-ai opened this issue Oct 17, 2022 · 3 comments · Fixed by #2881
Closed

Add more semantic convention attributes of Apache RocketMQ #2880

aaron-ai opened this issue Oct 17, 2022 · 3 comments · Fixed by #2881
Assignees
Labels
[label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide spec:trace Related to the specification/trace directory

Comments

@aaron-ai
Copy link
Member

aaron-ai commented Oct 17, 2022

Add more semantics convention attributes of Apache RocketMQ.

  1. messaging.rocketmq.message_group: message group is essential for FIFO message. Messages that belong to the same message group are always processed one by one within the same consumer group.
  2. messaging.rocketmq.delivery_timestamp: the timestamp in milliseconds that the delay message is expected to be delivered to consumer.
  3. messaging.rocketmq.delay_time_level: the delay time level for delay message, which determines the message delay time.
@aaron-ai aaron-ai added the spec:trace Related to the specification/trace directory label Oct 17, 2022
@aaron-ai aaron-ai changed the title Add "messaging.rocketmq.messsage_group" convention Add more semantics convention attributes of Apache RocketMQ Oct 17, 2022
@aaron-ai aaron-ai changed the title Add more semantics convention attributes of Apache RocketMQ Add more semantic convention attributes of Apache RocketMQ Oct 17, 2022
@carlosalberto
Copy link
Contributor

Overall good, although we don't have any actual semantic convention (for tracing) using a timestamp value. Also, we need actual examples or doc references for some of these values (e.g. I didn't know about delay type, but I found this: https://rocketmq.apache.org/docs/4.x/producer/07message3/)

Also, let's discuss it in tomorrow's Spec call, to double confirm we are good with this. We will post an update if you can't make it.

@carlosalberto carlosalberto added the [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide label Oct 17, 2022
@aaron-ai
Copy link
Member Author

aaron-ai commented Oct 18, 2022

Thanks for reply. We use either of delay_time_level and delivery_timestamp to determine the specified delay time for delay message, it depends on the version of RocketMQ client.

@carlosalberto
Copy link
Contributor

@jsuereth I was wondering whether you have any opinion regarding adding general trace attributes (special attention to the timestamp value).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants