Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampling: Each exporter should have isolated control over its sampler decision and custom processing #3284

Open
kalyanaj opened this issue Mar 3, 2023 · 0 comments
Assignees
Labels
spec:trace Related to the specification/trace directory

Comments

@kalyanaj
Copy link

kalyanaj commented Mar 3, 2023

[This is based on @jmacd's PR feedback in https://github.com/open-telemetry/opentelemetry-dotnet/pull/4206]

What are you trying to achieve?
With the current sampler and processor API, any decisions taken at the end of this pipeline can affect all exporters (if multiple exporters are configured).

What did you expect to see?
Each exporter should have isolated control over its sampler decision and custom processing.

Additional context.
[This is based on @jmacd's PR feedback in https://github.com/open-telemetry/opentelemetry-dotnet/pull/4206]:

"I feel there is an OTel specification-level problem here, possibly a discussion topic. I think this calls for a "v2" Sampler and Processor API that would correspond with the Metrics SDK's Reader. That is a way of specifying that each exporter should have isolated control over its sampler decision and custom processing and particularly that the Trace SDK should manage composition of sampler policies. See also #2179."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:trace Related to the specification/trace directory
Projects
None yet
Development

No branches or pull requests

2 participants