Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider additional JVM metrics from MicroProfile specification #3427

Closed
trask opened this issue Apr 21, 2023 · 8 comments
Closed

Consider additional JVM metrics from MicroProfile specification #3427

trask opened this issue Apr 21, 2023 · 8 comments
Assignees
Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory

Comments

@trask
Copy link
Member

trask commented Apr 21, 2023

From https://download.eclipse.org/microprofile/microprofile-metrics-5.0.0/microprofile-metrics-spec-5.0.0.pdf:

@trask trask added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory labels Apr 21, 2023
@trask trask assigned trask and unassigned jmacd Apr 21, 2023
@breedx-splk
Copy link
Contributor

As we discussed this morning, here's my input on these:

  • jvm.uptime - Seems useful. Maybe call it process.runtime.jvm.uptime and we can spec it as a DoubleCounter (monotonically increasing floating point seconds).
  • thread.max.count - I'm ok leaving this out of the initial stability set.
  • threadpool.* - I don't think these need to be in the initial group of stable metrics.
  • cpu.availableProcessors - Quite important when trying to get a comprehensive picture of compute utilization, but IMO this is not a JVM specific consideration and we could leave it out of the initial JVM set.
  • cpu.processCpuTime - Seems useful. Maybe call it process.runtime.jvm.cpuTime and we can spec it as a DoubleCounter (monotonically increasing floating point seconds).

@trask
Copy link
Member Author

trask commented Apr 28, 2023

we may need cpu.availableProcessors under jvm since jvm reports non-fractional (no millicores)

let's see about reporting cpu.processCpuTime as standard process.*

@jack-berg
Copy link
Member

Can we wait for a generic runtime uptime metric rather than introducing one that is JVM specific?

@trask
Copy link
Member Author

trask commented May 5, 2023

process.cpu.time or process.runtime.jvm.cpu.time?

some concern about process.cpu.time conflicting with collector

should process.cpu.time be opt-in on JVM side to avoid conflicting with collector?

@trask
Copy link
Member Author

trask commented May 9, 2023

Based on discussion today we are leaning towards process.runtime.jvm.cpu.time

@jackshirazi
Copy link

Are we also going to include the OS memory metrics available from JMX?

@trask
Copy link
Member Author

trask commented May 9, 2023

No but I agree those are useful, I'll open an issue to discuss / track 👍

@trask
Copy link
Member Author

trask commented May 9, 2023

I think we can close this now, the remaining issues are tracked in #3490, open-telemetry/semantic-conventions#1038 and #3473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory
Projects
Development

No branches or pull requests

5 participants