-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode #4023
Comments
Notice that google/docsy#331 is still open. |
Yes, there's base work that needs to be done first -- migrating to Bootstrap 5.3. That should get some attention in the next release (or so) :). |
@chalin Support for custom themes will unlock this? |
Yes, the feature is on its way -- probably next week, via version 0.10.0 of Docsy. |
As this has a clear outcome ("implement dark mode when docsy has it") I remove the |
Registry and Status pages look incorrect |
Came here to also say that the Registry page looks odd :-) |
Love it overall! We might want to check all Mermaid diagrams for weird color / transparency effects. See, for example, https://deploy-preview-4347--opentelemetry.netlify.app/docs/concepts/instrumentation-scope/ Mermaid has dark mode support, apparently. Check:
|
Thanks all for your feedback, it's much appreciated! I'll look into each issue. Keep'm coming ✨ |
Many of the code snippets have faded to illegible, at least for me. This screenshot is from the Collector Quick start page, but the issue is present on many other pages as well. |
@cartermp - here's a preview of the fix in google/docsy#1952, WDYT? |
Thanks a lot for this! |
Desired feature or idea: What would you like to see happen?
I would like to read the website at night comfortably, hence I would like the site to support dark mode automatically, based on the operating system setting.
.td-box--white
should be dark-mode compatible google/docsy#1967The text was updated successfully, but these errors were encountered: