Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #4023

Closed
8 of 9 tasks
Tracked by #4082
asafm opened this issue Feb 18, 2024 · 14 comments · Fixed by #4407
Closed
8 of 9 tasks
Tracked by #4082

Dark mode #4023

asafm opened this issue Feb 18, 2024 · 14 comments · Fixed by #4407
Assignees
Labels
design/style Front-end site design / styling enhancement New feature or request ux
Milestone

Comments

@asafm
Copy link
Contributor

asafm commented Feb 18, 2024

Desired feature or idea: What would you like to see happen?
I would like to read the website at night comfortably, hence I would like the site to support dark mode automatically, based on the operating system setting.


@svrnm
Copy link
Member

svrnm commented Feb 20, 2024

hey @asafm, we use docsy as hugo template, so it might be an option to bring this feature there to get it for the opentelemetry.io website. @chalin wdyt?

@svrnm svrnm added the enhancement New feature or request label Feb 20, 2024
@theletterf
Copy link
Member

Notice that google/docsy#331 is still open.

@chalin
Copy link
Contributor

chalin commented Feb 25, 2024

Yes, there's base work that needs to be done first -- migrating to Bootstrap 5.3. That should get some attention in the next release (or so) :).

@theletterf
Copy link
Member

@chalin Support for custom themes will unlock this?

@chalin
Copy link
Contributor

chalin commented Apr 5, 2024

Yes, the feature is on its way -- probably next week, via version 0.10.0 of Docsy.

@theletterf theletterf added the discussion Input from everyone is helpful to drive this forward label Apr 9, 2024
@svrnm svrnm added blocked and removed discussion Input from everyone is helpful to drive this forward labels Apr 16, 2024
@svrnm
Copy link
Member

svrnm commented Apr 16, 2024

As this has a clear outcome ("implement dark mode when docsy has it") I remove the discussion label, but I add blocked since this depends on docsy being 0.10

@svrnm svrnm added the ux label Apr 16, 2024
@chalin chalin self-assigned this Apr 22, 2024
@chalin chalin added this to the 24Q2 milestone Apr 22, 2024
@cartermp
Copy link
Contributor

cartermp commented Apr 24, 2024

The little collapsy arrow would probably look more visually distinct if it had a brighter color
image

▶️ Edit: tracked via:

@pellared
Copy link
Member

pellared commented Apr 25, 2024

Registry and Status pages look incorrect

▶️ Edit (@chalin)

@jpkrohling
Copy link
Member

jpkrohling commented Apr 25, 2024

Came here to also say that the Registry page looks odd :-)

▶️ Edit (@chalin)

@theletterf
Copy link
Member

theletterf commented Apr 25, 2024

Love it overall!

We might want to check all Mermaid diagrams for weird color / transparency effects. See, for example, https://deploy-preview-4347--opentelemetry.netlify.app/docs/concepts/instrumentation-scope/

Mermaid has dark mode support, apparently. Check:

▶️ Edit (@chalin)

@chalin
Copy link
Contributor

chalin commented Apr 25, 2024

Thanks all for your feedback, it's much appreciated! I'll look into each issue. Keep'm coming ✨

@tiffany76
Copy link
Contributor

tiffany76 commented Apr 25, 2024

Many of the code snippets have faded to illegible, at least for me. This screenshot is from the Collector Quick start page, but the issue is present on many other pages as well.

Screenshot from 2024-04-25 11-36-06

▶️ Edit (@chalin):

@chalin
Copy link
Contributor

chalin commented Apr 29, 2024

The little collapsy arrow would probably look more visually distinct if it had a brighter color ...

@cartermp - here's a preview of the fix in google/docsy#1952, WDYT?

@chalin chalin added the design/style Front-end site design / styling label Apr 30, 2024
@asafm
Copy link
Contributor Author

asafm commented Jun 1, 2024

Thanks a lot for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/style Front-end site design / styling enhancement New feature or request ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants