Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Adjust workflows so that they run on merge_group too #4973

Closed
Tracked by #4083
chalin opened this issue Aug 6, 2024 · 2 comments · Fixed by #4974
Closed
Tracked by #4083

[CI] Adjust workflows so that they run on merge_group too #4973

chalin opened this issue Aug 6, 2024 · 2 comments · Fixed by #4974
Assignees
Labels
CI/infra CI & infrastructure

Comments

@chalin chalin added the CI/infra CI & infrastructure label Aug 6, 2024
@chalin chalin self-assigned this Aug 6, 2024
@chalin
Copy link
Contributor Author

chalin commented Aug 6, 2024

@open-telemetry/docs-maintainers - please comment here once you are able to confirm that the workflows indeed trigger on a merge-group event. I'll reopen this issue until we get that confirmation. Thanks.

@chalin chalin reopened this Aug 6, 2024
@chalin
Copy link
Contributor Author

chalin commented Aug 9, 2024

Ah, I see that merge_group events are being processed. We can actually filter for this kind of event: https://github.com/open-telemetry/opentelemetry.io/actions/workflows/check-links.yml?query=event%3Amerge_group

For example, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/10322514304:

image

The hash links to 1e4f5b2. So I assume that the commit hash was the result of a PR update applied to #5015 while it was in the merge queue.

So, it seems to be working as expected. I'm going to close this now. Feel free to reopen if there's something that I missed.

@chalin chalin closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant