From c76cb09c8aee218dc576ec8fdc2fac01cf679acf Mon Sep 17 00:00:00 2001
From: gregor <gregor.zeitlinger@grafana.com>
Date: Tue, 16 May 2023 11:54:24 +0200
Subject: [PATCH] add changelog

---
 CHANGELOG.md                                       | 14 ++++++++++++++
 .../process-runtime-jvm-metrics-experimental.yaml  |  4 +++-
 .../runtime-environment-metrics.md                 |  6 +++---
 3 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a63a74d990..a0126525c6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -94,3 +94,17 @@ release.
   ([#17](https://github.com/open-telemetry/opentelemetry-specification/pull/17))
 - Mark service.version as stable.
   ([#106](https://github.com/open-telemetry/semantic-conventions/pull/106))
+- BREAKING: Add namespaces to JVM metric attributes ([#20](https://github.com/open-telemetry/semantic-conventions/pull/20)).
+  - Memory metric attribute renames
+    - Applies to metrics
+      - `metric.process.runtime.jvm.memory.usage`
+      - `metric.process.runtime.jvm.memory.init`
+      - `metric.process.runtime.jvm.memory.committed`
+      - `metric.process.runtime.jvm.memory.limit`
+      - `metric.process.runtime.jvm.memory.usage_after_last_gc`
+    - Rename `memory` to `memory.type`
+    - Rename `pool` to `memory.pool.name`
+  - Rename `process.runtime.jvm.gc.duration` metric attribute `gc` to `gc.name`
+  - Rename `process.runtime.jvm.gc.duration` metric attribute `action` to `gc.action`
+  - Rename `process.runtime.jvm.threads.count` metric attribute `daemon` to `thread.daemon`
+  - Rename `attributes.process.runtime.jvm.buffer` metric attribute `pool` to `buffer.pool.name`
diff --git a/semantic_conventions/metrics/process-runtime-jvm-metrics-experimental.yaml b/semantic_conventions/metrics/process-runtime-jvm-metrics-experimental.yaml
index e0a3721d4b..130ab50eb0 100644
--- a/semantic_conventions/metrics/process-runtime-jvm-metrics-experimental.yaml
+++ b/semantic_conventions/metrics/process-runtime-jvm-metrics-experimental.yaml
@@ -35,7 +35,9 @@ groups:
     type: attribute_group
     brief: "Describes JVM buffer metric attributes."
     attributes:
-      - ref: pool
+      - id: buffer.pool.name
+        type: string
+        requirement_level: recommended
         brief: Name of the buffer pool.
         examples: [ "mapped", "direct" ]
         note: >
diff --git a/specification/metrics/semantic_conventions/runtime-environment-metrics.md b/specification/metrics/semantic_conventions/runtime-environment-metrics.md
index 9791f63651..858e387d80 100644
--- a/specification/metrics/semantic_conventions/runtime-environment-metrics.md
+++ b/specification/metrics/semantic_conventions/runtime-environment-metrics.md
@@ -379,7 +379,7 @@ This metric is obtained from [`BufferPoolMXBean#getMemoryUsed()`](https://docs.o
 <!-- semconv metric.process.runtime.jvm.buffer.usage(full) -->
 | Attribute  | Type | Description  | Examples  | Requirement Level |
 |---|---|---|---|---|
-| `pool` | string | Name of the buffer pool. [1] | `mapped`; `direct` | Recommended |
+| `buffer.pool.name` | string | Name of the buffer pool. [1] | `mapped`; `direct` | Recommended |
 
 **[1]:** Pool names are generally obtained via [BufferPoolMXBean#getName()](https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/BufferPoolMXBean.html#getName()).
 <!-- endsemconv -->
@@ -398,7 +398,7 @@ This metric is obtained from [`BufferPoolMXBean#getTotalCapacity()`](https://doc
 <!-- semconv metric.process.runtime.jvm.buffer.limit(full) -->
 | Attribute  | Type | Description  | Examples  | Requirement Level |
 |---|---|---|---|---|
-| `pool` | string | Name of the buffer pool. [1] | `mapped`; `direct` | Recommended |
+| `buffer.pool.name` | string | Name of the buffer pool. [1] | `mapped`; `direct` | Recommended |
 
 **[1]:** Pool names are generally obtained via [BufferPoolMXBean#getName()](https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/BufferPoolMXBean.html#getName()).
 <!-- endsemconv -->
@@ -417,7 +417,7 @@ This metric is obtained from [`BufferPoolMXBean#getCount()`](https://docs.oracle
 <!-- semconv metric.process.runtime.jvm.buffer.count(full) -->
 | Attribute  | Type | Description  | Examples  | Requirement Level |
 |---|---|---|---|---|
-| `pool` | string | Name of the buffer pool. [1] | `mapped`; `direct` | Recommended |
+| `buffer.pool.name` | string | Name of the buffer pool. [1] | `mapped`; `direct` | Recommended |
 
 **[1]:** Pool names are generally obtained via [BufferPoolMXBean#getName()](https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/BufferPoolMXBean.html#getName()).
 <!-- endsemconv -->