Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are jvm.class.loaded and jvm.class.unloaded names correct even if .count is adopted for (monotonic) Counters? #273

Closed
trask opened this issue Aug 18, 2023 · 1 comment
Assignees

Comments

@trask
Copy link
Member

trask commented Aug 18, 2023

I believe this is the last question we have about JVM metric naming.

I think that these names are correct even if .count is adopted for (monotonic) Counters in #260, but opening this issue to discuss.

The reason I think these names are still correct, as opposed to renaming them to jvm.class.loaded.count and jvm.class.unloaded.count, is that the "implicit attribute namespace" of jvm.class seems more useful (e.g. maybe jvm.class.name or jvm.class.package) compared to the alternative namespace if we renamed them to end in .count.

@trask
Copy link
Member Author

trask commented Aug 28, 2023

Discussed in Semantic Convention SIG meeting today, and consensus is that #260 will likely take a while to resolve given that it would also impact the prometheus mappings, and it's ok to go ahead and stabilize with the current metric names jvm.class.loaded and jvm.class.unloaded (and given that if .count ends up being recommended for monotonic counters, it will never be a MUST and so it's ok if JVM metrics diverge from the recommendation in this case particular case, especially given the namespacing argument above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants