Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe we can set the requirement level to something #353

Closed
trask opened this issue Sep 29, 2023 · 2 comments
Closed

Maybe we can set the requirement level to something #353

trask opened this issue Sep 29, 2023 · 2 comments
Assignees

Comments

@trask
Copy link
Member

trask commented Sep 29, 2023

Maybe we can set the requirement level to something
'conditionally_required: if instrumented technology supports different transports and value cannot be inferred from other attributes such as network.protocol.name'

This would eliminate the concern for ports and also would require instrumentations to populate it whenever it's helpful.

Originally posted by @lmolkova in #289 (comment)

@trask
Copy link
Member Author

trask commented Oct 3, 2023

Removing from HTTP semconv stability project since HTTP semconv is already overriding network.transport to be conditionally required.

@trask
Copy link
Member Author

trask commented Oct 28, 2023

Closing, I think we've come to consensus on not adding requirement levels in the attribute registry.

@trask trask closed this as completed Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants