-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename http.route
to http.request.route
?
#378
Comments
I would agree with not changing it. In particular we have customers who rely on checking |
Ah, right, sorry, I got confused and was thinking of I'm...ambivalent I guess, since whatever process we have to convert on the backend can work for |
(Aside: It is unclear what the upvotes on the issue mean. "Yes" to the question in the issue title whether we should rename, or "Agree" to the sentence in the description that we should rather keep the name as-is) |
I'm also in favor of not changing and keep it as-is. |
Keep it as |
I guess we have a majority on keeping it as |
closing, this is a great reason to keep it where it is, thx @JamesNK |
After #374,
http.route
will be the onlyhttp.*
attribute that is not under eitherhttp.request.*
orhttp.response.*
.I think I'm in favor of keeping
http.route
as-is, but wanted to open this to give others a chance to weigh in if they feel differently.The text was updated successfully, but these errors were encountered: